feat: User.Id can now be overriden (set to null) in Global mode#5039
Merged
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Features ✨
Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
jamescrosswell
commented
Mar 18, 2026
jamescrosswell
commented
Mar 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5039 +/- ##
==========================================
+ Coverage 73.87% 74.07% +0.20%
==========================================
Files 506 507 +1
Lines 18247 18255 +8
Branches 3564 3568 +4
==========================================
+ Hits 13480 13523 +43
+ Misses 3891 3865 -26
+ Partials 876 867 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how User.Id is populated from InstallationId when Global Mode is enabled, so that applications can explicitly clear/override the value (e.g., set it to null) without it being re-applied during event enrichment.
Changes:
- Add a new
GlobalRootScopeIntegrationdefault integration that setsscope.User.Idfromoptions.InstallationIdat startup (Global Mode only). - Update
Enricherto not apply theInstallationIdfallback in Global Mode (so user overrides aren’t re-written). - Update/extend tests and Verify snapshots to account for the new default integration and changed behavior.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/Sentry/Integrations/GlobalRootScopeIntegration.cs |
New integration to set User.Id on the root scope in Global Mode. |
src/Sentry/Internal/Enricher.cs |
Stops applying InstallationId fallback when Global Mode is enabled. |
src/Sentry/SentryOptions.cs |
Registers the new integration as a default integration. |
test/Sentry.Tests/Integrations/GlobalRootScopeIntegrationTests.cs |
Adds tests covering the new integration and updated enricher behavior. |
test/Sentry.Tests/SentryClientTests.cs |
Adjusts tests around fallback User.Id behavior. |
test/Sentry.Tests/SentryOptionsTests.verify.cs + *.verified.txt |
Narrows snapshot scope to integration-registration logs and updates expected output. |
src/Sentry/PlatformAbstractions/FrameworkInfo.cs |
Adds an additional .NET Framework release key mapping for 4.8.1. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Thank you for the PR! |
Flash0ver
reviewed
May 5, 2026
| {533320, "4.8.1"}, | ||
| {533325, "4.8.1"} | ||
| {533325, "4.8.1"}, | ||
| {533509, "4.8.1"} |
Member
There was a problem hiding this comment.
question: how did you notice this?
CI just started to fail when a new servicing update is applied to the runners?
Collaborator
Author
There was a problem hiding this comment.
I think I ran the unit tests on my Windows box which is running the latest version of Windows and service packs, which broke the tests. Presumably those are now hitting the CI runners.
- Add Scope + SubstituteConfigureScope to the disabled test, with assertion that scope.User.Id remains null - Add hub.Received(1).ConfigureScope assertion to both enabled tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
- Use nameof(GlobalRootScopeIntegration) in Skip.If messages for easier navigation - Move comment to after // Arrange in CaptureEvent_UserIsNull_SetsFallbackUserId to match CaptureTransaction_UserIsNull_SetsFallbackUserId Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4172